DM
All learning areas
Quality

Code Review

Review correctness, clarity, risk, and operability while helping people grow.

Topic library

Correctness and edge casesReadability and namingTest qualityError handlingSecurity and privacyAccessibilityPerformanceDatabase impactBackward compatibilityObservabilityRollout riskUnnecessary complexityConstructive feedback

Featured guides

Practical starting points for the highest-value topics.

Review in layers

Start with intent and risk before discussing local style.

  1. Understand the user problem, acceptance criteria, and intended behavior.
  2. Check architecture, data flow, permissions, and failure behavior.
  3. Inspect tests, migrations, compatibility, and rollout strategy.
  4. Review readability, naming, duplication, and maintainability.
  5. Clearly label blocking issues, suggestions, questions, and praise.

Key idea: Do not polish an implementation that solves the wrong problem.

Give useful feedback

Make comments specific, respectful, and easy to act on.

  1. Describe the observed risk instead of judging the author.
  2. Ask a question when you may be missing context.
  3. Explain why a requested change matters.
  4. Offer an example without demanding your exact implementation.
  5. Resolve conversations explicitly after agreement or follow-up.

Key idea: The goal is shared understanding and better software, not winning.

Review production readiness

Look beyond whether the happy path compiles.

  1. Check logs, metrics, alerts, and actionable error context.
  2. Ask how partial failure, retries, duplicates, and timeouts behave.
  3. Verify migration order and compatibility with old clients or workers.
  4. Confirm rollout, rollback, and feature-flag ownership.
  5. Ensure support and on-call teams can diagnose the change.

Key idea: A change is not complete until it can be operated safely.